security: httpOnly cookies, rate limiting, nginx headers, SSE sanitization
Auth / token storage: - JWT is now set as an httpOnly Secure SameSite=Lax cookie on login - Add POST /auth/logout endpoint that clears the cookie - get_current_member falls back to rh_token cookie when no Authorization header - WebSocket auth now accepts cookie (rh_token) or optional ?token= query param - Frontend removes all localStorage JWT access; uses credentials:"include" on every fetch so the httpOnly cookie is sent automatically - Replace clearToken() with logout() that calls the server logout endpoint - Non-sensitive rh_session flag in localStorage used only for client-side routing Rate limiting: - Add slowapi>=0.1.9 dependency - /auth/login limited to 10 req/min per IP - /auth/register limited to 5 req/min per IP Nginx security headers: - Add X-Frame-Options, X-Content-Type-Options, Referrer-Policy, X-XSS-Protection, Permissions-Policy to all responses SSE error leakage: - songs.py nc-scan/stream no longer leaks str(exc) to clients Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -16,13 +16,19 @@ router = APIRouter(tags=["websocket"])
|
||||
async def version_ws(
|
||||
version_id: uuid.UUID,
|
||||
websocket: WebSocket,
|
||||
token: str = Query(...),
|
||||
token: str | None = Query(None),
|
||||
):
|
||||
"""WebSocket endpoint. Requires a valid JWT passed as ?token=<jwt>."""
|
||||
# Validate token before accepting the connection
|
||||
"""
|
||||
WebSocket endpoint. Authentication via:
|
||||
- ?token=<jwt> query parameter, or
|
||||
- rh_token httpOnly cookie (sent automatically by the browser)
|
||||
"""
|
||||
raw_token = token or websocket.cookies.get("rh_token")
|
||||
async for session in get_session():
|
||||
try:
|
||||
payload = decode_token(token)
|
||||
if not raw_token:
|
||||
raise ValueError("no token")
|
||||
payload = decode_token(raw_token)
|
||||
member_id = uuid.UUID(payload["sub"])
|
||||
member = await MemberRepository(session).get_by_id(member_id)
|
||||
if member is None:
|
||||
|
||||
Reference in New Issue
Block a user